Mill atc configuration

Now orient.enable after orient is complete is low
But after orient is complete spindle.0.is-oriented is low. Even if spindle stop exactly on orient position.
Still play with orient pid but often after orient is complete spindle turn little and is out of orient.tolerance.
Actual hal
 

But after orient is complete spindle.0.is-oriented is low. Even if spindle stop exactly on orient position.

Yes, I think that is the intended behavior  but I don't have a system to actually verify this.

'orient.is-oriented' True -> 'spindle.0.is-oriented' True -> 'spindle.0.orient' False -> 'orient.enable' False -> 'orient.is-oriented' False -> 'spindle.0.is-oriented' False

If you need a signal that stays True after a completed orient then you can use 'spindle.0.locked' which stays True until M3,M4 or M5 command

linuxcnc.org/docs/html/man/man9/motion.9.html

Still play with orient pid but often after orient is complete spindle turn little and is out of orient.tolerance.

Depending on the inertia of the spindle and the spindle drive I would expect that to be a problem and I don't really know how to deal with that if the spindle drive cannot get the spindle to stop quickly enough (unless maybe with a mechanical brake).

Now my Pid working like that. Start M19 R180 which is 114 encoder count. Spindle start turn from encoder count 0 and go to about 125 and start oscilation 125-124, 124-123, 123-122, 122-121, 121-120, 120-119, 119-118, 118-117, 117-116, 116-115, 115-114 and hit orient but past some micro time when relays off and and spindle stop. Sometimes on 113, 114, 115,116
That should work orient?

I'm afraid I can't really help you with the PID tuning but maybe you get some inspiration from this thread:
forum.linuxcnc.org/24-hal-components/458...-solved-yay?start=60

Today try rigid taping but dont working.
Try to make M6 with command G33.1 Z-15 K1
Turn spindle with hand tapping start after hit index  Z axis go to Z-1 after that  Z axis dont move again.
Spindle-at-speed is still High
spindle.0.index-enable After start rigid tapping is set to High but after hit index is set to Low and dont go to High anymore.
 

Spindle-at-speed is still High
spindle.0.index-enable After start rigid tapping is set to High but after hit index is set to Low and dont go to High anymore.

Sounds correct.
I think I may have made a mistake resetting the encoder with the input-index. So remove this:

net spindle-input-index <= hm2_5i25.0.encoder.04.input-index
net spindle-input-index <= hm2_5i25.0.encoder.04.reset

and add this instead:

net spindle-index-enable <= hm2_5i25.0.encoder.04.input-index